✨ improve hostname detection via getent cmd#5492
Merged
Conversation
This change improves hostname detection using `getent` command for IPv4 and IPv6 for UNIX systems. The new flow to detect the hostname is: 1. Keep running `hostname -f` to retrieve the configured fqdn which has proven to be a reliable way 2. If the output is `localhost`, we now run `getent hosts 127.0.0.1` (first entry wins) 3. If IPv4 is not configured or we still get `localhost`, then we try IPv6 via `getent hosts ::1` (like above, first entry wins) Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
Contributor
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves hostname detection using
getentcommand for IPv4 and IPv6 for UNIX systems.The new flow to detect the hostname is:
hostname -fto retrieve the configured fqdn which has proven to be a reliable waylocalhost, we now rungetent hosts 127.0.0.1(first entry wins)localhost, then we try IPv6 viagetent hosts ::1(like above, first entry wins)